-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Send Email Node): Add content-id for email attachments #3632
Conversation
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3632 +/- ##
==========================================
- Coverage 27.69% 27.69% -0.01%
==========================================
Files 2948 2948
Lines 180869 180871 +2
Branches 19635 19635
==========================================
Hits 50090 50090
- Misses 130034 130036 +2
Partials 745 745
☔ View full report in Codecov by Sentry. |
Thanks for the PR @pemontto 🙌 |
* master: fix(core): Prevent app crashes because of unhandled promises in poll and trigger nodes (#6278) fix(Postgres Node): Remove reusable connections (no-changelog) (#6259) ci(editor): Enfore stricter linting rules from `eslint-plugin-vue` (no-changelog) (#6242) fix(Strava Trigger Node): Fix issue with delete events failing to display data (#6277) feat(SSH Node): Credentials test (#6279) feat(Send Email Node): Add content-id for email attachments (#3632) feat(core): Include openssh in the base docker image (no-changelog) (#6275) # Conflicts: # packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts
Got released with |
✨ Feature
This PR adds
Content-ID
s (CIDs
) for email attachments based on their property name. Using CIDs is the most widely supported way to include inline images in HTML emails.Using the workflow below you can send HTML emails with inline images from the attached files
View sample workflow
🐛 Bug
This also fixes an issues where the error object has a circular reference with certificate errors which makes things very hard to debug, particularly in large workflows. Instead of seeing this:
The error now looks like this: